Some updates required for use with Iniquity 3#16
Open
ispyhumanfly wants to merge 15 commits intorickparrish:masterfrom
Open
Some updates required for use with Iniquity 3#16ispyhumanfly wants to merge 15 commits intorickparrish:masterfrom
ispyhumanfly wants to merge 15 commits intorickparrish:masterfrom
Conversation
I also ported over the build.cmd and what not over to the more 'npm' way of doing things.
Owner
|
Thanks for these changes! At quick glance they look good, but I hope to have the time to take a closer look over the weekend. |
Author
|
Very cool, no rush on my end :) I will say that fTelnet is a crucial part of iniquity 3. Thank you again for creating it. |
Author
Hey Rick, any thoughts on my pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Rick, it's been a long long while. Anyways, I've loved fTelnet for so long. Truly it's the best of its kind. Even cooler you're on github now, and, are all about TypeScript. Anyways, this adventure of mine began when I was wondering if I could just include fTelnet as an npm module in my project... and, from there I started expanding just a little in terms of its options. Just some things I needed. But now, this repo can be installed via npm. Also, there is a development server for easy testing fTelnet against. To be honest, I believe I could make it production quality if you're interested. Then fTelnet could maybe have the proxy and everything ready to go for people! Just ideas... let me know if anything I've done here is of interest to you.