Open
Conversation
Collaborator
|
Can you fix the tests? I think you just have to add Run the tests locally, you can find which file is the problem exactly: https://github.com/richibrics/IoTuring/blob/main/docs/DEVELOPMENT.md#tests Run it in docker so you can use the same python version. |
infeeeee
reviewed
Jul 25, 2024
Contributor
Author
|
That's what I get for doing this quickly on my train ride. I need to stop
using
`git add .`
Sorry for that.
|
infeeeee
reviewed
Sep 24, 2024
Collaborator
infeeeee
left a comment
There was a problem hiding this comment.
Nice. Other things to do:
- There is also a predefined choice list in
Terminalentity, please upgrade that toTypedDictas well - I just searched for Callback and I still found some methods in some entities where MQTTMessage could be hinted
Co-authored-by: infeeeee <gyetpet@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of them may be debated upon. Most of the changes are return hints