Skip to content

add various type hints#119

Open
lockenkop wants to merge 8 commits intorichibrics:mainfrom
lockenkop:type_hinting
Open

add various type hints#119
lockenkop wants to merge 8 commits intorichibrics:mainfrom
lockenkop:type_hinting

Conversation

@lockenkop
Copy link
Contributor

Some of them may be debated upon. Most of the changes are return hints

@infeeeee
Copy link
Collaborator

Can you fix the tests? I think you just have to add from __future__ import annotations at the top of some files, usually that's all.

Run the tests locally, you can find which file is the problem exactly: https://github.com/richibrics/IoTuring/blob/main/docs/DEVELOPMENT.md#tests Run it in docker so you can use the same python version.

@lockenkop
Copy link
Contributor Author

lockenkop commented Jul 25, 2024 via email

Copy link
Collaborator

@infeeeee infeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Other things to do:

  • There is also a predefined choice list in Terminal entity, please upgrade that to TypedDict as well
  • I just searched for Callback and I still found some methods in some entities where MQTTMessage could be hinted

Co-authored-by: infeeeee <gyetpet@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants