Skip to content

Update mirrors#5

Open
mistval wants to merge 2 commits into
rewonc:masterfrom
mistval:update_mirrors
Open

Update mirrors#5
mistval wants to merge 2 commits into
rewonc:masterfrom
mistval:update_mirrors

Conversation

@mistval
Copy link
Copy Markdown

@mistval mistval commented Oct 4, 2020

Hi,

This PR updates the mirror list based on the current info at: https://www.edrdg.org/wwwjdic/wwwjdicmirrors.html

In summary:

  1. The Japan mirror has been removed. It actually still responds, but it always returns an empty result, and it is no longer listed as an official mirror.
  2. The Canada mirror has been removed. It doesn't respond at all and it is no longer listed as an official mirror.
  3. There are now two Australian mirrors. I added them as australia_monash and australia_melbourne. I left austrailia for backwards compatibility and updated it to point to the monash mirror (the previous address 302 redirects there).

@mistval mistval changed the title update mirrors Update mirrors Oct 4, 2020
Comment thread index.js

function mapMirror(key) {
var map = {
"austrailia": "http://www.csse.monash.edu.au/~jwb/cgi-bin/wwwjdic?",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You update the map but you don't update the row above with the correct keys. On my repo I pulled these out and made this map a const and replaced the row above with map.keys() to keep them forever in sync

Copy link
Copy Markdown

@Zergleb Zergleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix array of mirrors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants