fix (timeout errors): Standardize on {:error, :timeout}#102
Open
s3cur3 wants to merge 1 commit intorevelrylabs:masterfrom
Open
fix (timeout errors): Standardize on {:error, :timeout}#102s3cur3 wants to merge 1 commit intorevelrylabs:masterfrom
{:error, :timeout}#102s3cur3 wants to merge 1 commit intorevelrylabs:masterfrom
Conversation
The `can't block js workers` test was flaky locally for me because sometimes a task would result in `{:error, "Call timed out."}` and others it would be `{:error, :timeout}`. The string version was coming from the NodeJS.Supervisor, while the atom came from NodeJS.Worker. Since the atom version is more idiomatic to Elixir, I thought it'd be good to standardize on that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! Thanks for this library. We're happy users of it at Jump.☺️
In production, we were seeing different values returned on timeouts. This was reflected in the test suite by the
can't block js workerstest being flaky: sometimes a task would result in{:error, "Call timed out."}and others it would be{:error, :timeout}.The string version was coming from the NodeJS.Supervisor, while the atom came from NodeJS.Worker. Since the atom version is more idiomatic to Elixir, I thought it'd be good to standardize on that.