Fix incorrect block updates for doors#190
Merged
Merged
Conversation
colbster937
pushed a commit
to WebMCDevelopment/WebMCUberBukkit
that referenced
this pull request
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Pull Request
Description
Correctly fixes the issue described in #184 where placing a door next to an opened trap door would cause the bottom half of the door to be broken and a door item to be dropped on the floor. When powering the remaining upper half of the door with a redstone torch, the torch would be removed and another door item would be dropped.
The actual cause of this issue is a CraftBukkit change in ItemDoor.java which sends a block update from the perspective of a redstone wire, in order to instantly trigger redstone updates for the door. This behavior was later reverted in CraftBukkit.
Related Issues / Discussions
Motivation and Context
#184 introduced a bug where if a door is broken at the top half, the bottom half is not removed, allowing for half-door blocks to be created.
Type of Change
Please tick all that apply:
Testing Performed
mvn clean packageTest details:
Compatibility Considerations
Checklist
Please confirm the following: