Skip to content

Fix incorrect block updates for doors#190

Merged
RhysB merged 1 commit into
masterfrom
fix-door-block-updates
Apr 29, 2026
Merged

Fix incorrect block updates for doors#190
RhysB merged 1 commit into
masterfrom
fix-door-block-updates

Conversation

@zavdav

@zavdav zavdav commented Apr 22, 2026

Copy link
Copy Markdown
Member

📌 Pull Request

Description

Correctly fixes the issue described in #184 where placing a door next to an opened trap door would cause the bottom half of the door to be broken and a door item to be dropped on the floor. When powering the remaining upper half of the door with a redstone torch, the torch would be removed and another door item would be dropped.

The actual cause of this issue is a CraftBukkit change in ItemDoor.java which sends a block update from the perspective of a redstone wire, in order to instantly trigger redstone updates for the door. This behavior was later reverted in CraftBukkit.

Related Issues / Discussions

Motivation and Context

#184 introduced a bug where if a door is broken at the top half, the bottom half is not removed, allowing for half-door blocks to be created.

Type of Change

Please tick all that apply:

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ⚡ Performance improvement
  • 🧩 New feature (non-breaking)
  • 🔧 Refactor / cleanup (no functional changes)
  • 🔥 Crash / exploit fix
  • 📚 Documentation update
  • ❗ Breaking change (may affect plugins or server behavior)

Testing Performed

  • Compiled successfully with mvn clean package
  • Tested on a Beta 1.7.3 server
  • Existing functionality verified
  • Edge cases considered

Test details:

Tested on local server, verified the duplication glitch to be fixed and the correct removal of the entire door block to take place when breaking it at the top half and bottom half.

Compatibility Considerations

  • No known compatibility impact
  • Potential plugin impact (described below)
  • Network / protocol (Netcode) behavior changed
  • Configuration change required

Checklist

Please confirm the following:

  • No unnecessary formatting or whitespace-only changes
  • Changes are compatible with Minecraft Beta 1.7.3
  • No dependencies have been added without discussion with the RetroMC team

@zavdav zavdav added the bug Something isn't working label Apr 22, 2026
@zavdav zavdav requested a review from a team April 22, 2026 18:53

@RhysB RhysB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed

@RhysB RhysB merged commit de77e47 into master Apr 29, 2026
3 checks passed
colbster937 pushed a commit to WebMCDevelopment/WebMCUberBukkit that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants