fix(ctrl): Add fallback for null defaultOrganization during OIDC login#183
Merged
lbroudoux merged 1 commit intoJun 9, 2026
Merged
Conversation
lbroudoux
requested changes
Jun 9, 2026
lbroudoux
left a comment
Member
There was a problem hiding this comment.
I would have used 403 instead of 400 and I think some code can be extracted into the same utilitty method to avoid duplication.
Contributor
Author
|
You are completely right about the I'll push those changes up shortly! |
Ensures that if a user's defaultOrganization is null, the AuthenticationController automatically falls back to the first available organization instead of throwing a NullPointerException during JWT token generation. Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
5904d77 to
d88eefd
Compare
Contributor
Author
|
I've just pushed an update to address both points:
Let me know if everything looks good! |
lbroudoux
approved these changes
Jun 9, 2026
lbroudoux
left a comment
Member
There was a problem hiding this comment.
This looks all good. Thanks for the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
NullPointerExceptionduring OIDC login when a user'sdefaultOrganizationis unset.The
AuthenticationControllernow checks if the default organization is null. If it is, it automatically falls back to the first organization the user is a member of, allowing JWT token generation to succeed gracefully.Related Issues:
Fixes #182