Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
annatraussnig
approved these changes
May 21, 2026
Comment on lines
-1
to
-4
| /* eslint-disable @typescript-eslint/no-var-requires */ | ||
| const withBundleAnalyzer = require('@next/bundle-analyzer')({ | ||
| enabled: process.env.ANALYZE === 'true', | ||
| }) |
Contributor
There was a problem hiding this comment.
not using this anymore?
Contributor
Author
There was a problem hiding this comment.
next 16 has a built-in one (did you ever use this?)
| import { NextRequest, NextResponse } from 'next/server' | ||
|
|
||
| export async function middleware(req: NextRequest) { | ||
| export async function proxy(req: NextRequest) { |
Comment on lines
+5
to
+12
| const pathPrefix = | ||
| discussion.document?.meta?.template === 'article' ? '/dialog' : '' | ||
|
|
||
| const href = comment?.id | ||
| ? `${pathPrefix}${discussion.path}?focus=${comment.id}` | ||
| : `${pathPrefix}${discussion.path}` | ||
|
|
||
| return href |
Contributor
There was a problem hiding this comment.
are all these dialog changes in this pr's scope?
Contributor
Author
There was a problem hiding this comment.
yes/no, they were attempts to fix the broken vercel behavior but also don't make things worse since we were getting deprecation warnings on using the 'url' package anyway.
| "cloc": "find . -name '*.js' -not -path \"./node_modules*\" -not -path \"./.next*\" | xargs wc -l", | ||
| "lint": "next lint", | ||
| "analyze": "ANALYZE=true next build", | ||
| "analyze": "next experimental-analyze", |
Contributor
There was a problem hiding this comment.
ah, this answers my first question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade all the apps to Next.js v16 for compatibility with the latest next-sanity package (required by #1402)
Caveat: this breaks www comment links, but on Vercel only, where path matching is broken (the
x-matched-pathheader matches on the top-level[...path]route instead of/dialog/[...path]). After confirming that this does not happen on Heroku, we accept this issue in order to move forward.