Skip to content

Release#301

Merged
HardNorth merged 5 commits into
masterfrom
develop
Sep 25, 2025
Merged

Release#301
HardNorth merged 5 commits into
masterfrom
develop

Conversation

@HardNorth

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Sep 25, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HardNorth HardNorth requested a review from Copilot September 25, 2025 15:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the log time parameter type from Date to Comparable<? extends Comparable<?>> throughout the codebase to support more flexible timestamp formats while maintaining backward compatibility with legacy loggers.

Key changes:

  • Updated method signatures in ReportPortal and ItemTreeReporter classes to use generic Comparable types for log time parameters
  • Added overloaded setter methods in SaveLogRQ to support both Date and Comparable time types
  • Enhanced type safety with proper annotations (@nonnull, @nullable)

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
SaveLogRQ.java Added Date-specific setter overload and consolidated imports
Issue.java Updated submitDate field type from Object to Comparable
ItemTreeReporter.java Updated method signatures to use Comparable for logTime parameters
ReportPortal.java Updated static methods to accept Comparable logTime with proper annotations
LaunchImpl.java Refactored subscription chain for better performance
CHANGELOG.md Added documentation for the changes
Comments suppressed due to low confidence (1)

src/main/java/com/epam/ta/reportportal/ws/model/issue/Issue.java:76

  • The getter method still returns Object type while the field type has been changed to Comparable>. The return type should be updated to match the field type for consistency.
		public Object getSubmitDate() {
			return submitDate;
		}

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/main/java/com/epam/reportportal/service/ReportPortal.java Outdated
@HardNorth HardNorth merged commit fd54581 into master Sep 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants