Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures all logs are sent before JVM exit by implementing a wait mechanism for log batches to complete processing before the launch finishes.
- Added logging completion tracking with atomic counters and waiter mechanism
- Updated test expectations to account for additional launch completion logs
- Enhanced documentation for the Waiter utility class
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| LaunchImpl.java | Implements log completion waiting mechanism using LoggingSubscriber counter and Waiter utility |
| LoggingSubscriber.java | Added atomic counter to track processed log batches and made class non-final |
| StaticStructuresUtils.java | Added constant and utility method for launch completion log messages |
| ReportPortalLoggingTest.java | Updated test verifications to expect 2 log calls and filter out launch completion messages |
| LaunchTest.java | Added batch log response simulations to accommodate new logging behavior |
| LaunchLoggingTest.java | Updated import to use LoggingSubscriber instead of generic FlowableSubscriber |
| Waiter.java | Enhanced documentation with comprehensive javadoc for the till() method |
| gradle-wrapper.properties | Updated Gradle wrapper version from 7.6.4 to 7.6.5 |
| CHANGELOG.md | Added changelog entry documenting the fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.