Skip to content

fix: revision part in cba urls #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flipsimon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: revision part in cba urls #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/repco-core/src/datasource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ export interface DataSource {
fetchByUri(uri: string): Promise<SourceRecordForm[] | null>
fetchByUriBatch(uris: string[]): Promise<SourceRecordForm[]>
/**
* Determines whether the data source is capable of fetching records by UID.
* Determines whether the data source is capable of fetching a particular uri
*
* @param uid - The UID of the record to fetch.
* @param uri The uri in question
* @returns `true` if the data source can fetch the record, `false` otherwise.
*/
canFetchUri(uri: string): boolean
Expand Down
2 changes: 1 addition & 1 deletion packages/repco-core/src/datasources/cba.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ export class CbaDataSource implements DataSource {
type: parts[1],
id: parts[2],
}
} else if (parts[1] === 'r') {
} else if (parts[0] === 'r') {
if (parts.length !== 4) return null
return {
kind: 'revision',
Expand Down