adding assignment two to assignment two branch includes completed sql file and logical data model files #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes sql file and ERD png file
DwardEE
approved these changes
Aug 20, 2025
DwardEE
left a comment
DwardEE
left a comment
There was a problem hiding this comment.
Great work!
Beautiful logical model.
For the windowed functions, you chose ROW_NUMBER() instead of DENSE_RANK(). That’s still valid, but it means if the same customer visits twice on the same date, you’ll count them separately. Using DENSE_RANK() would collapse same-date visits into one.
Overall, this is a strong submission with only minor tweaks needed (mainly swapping to DENSE_RANK() and practicing the COUNT() OVER form).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.