Use librevox execute_app for all channel commands#21
Open
henrikbjorn wants to merge 3 commits into
Open
Conversation
Replace manual sendmsg string building with librevox's execute_app API. This aligns with how librevox models application execution and removes the raw ESL protocol construction from switest. - answer, hangup, play_audio, send_dtmf all use execute_app - Drop wait: parameter from action methods (execute_app blocks until CHANNEL_EXECUTE_COMPLETE, which is the right semantic for tests) - hangup_all sends hangups in parallel via Async::Barrier with timeout - Update MockSession to mirror execute_app header construction - Use Client.start for connection setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execute_appAPI foranswer,hangup,play_audio, andsend_dtmfwait:parameter from action methods —execute_appblocks untilCHANNEL_EXECUTE_COMPLETE, which is the correct semantic for a test frameworkhangup_allwithAsync::Barrierand a timeout safety netClient.startfor connection setup