Skip to content

Match edit stability, schedule warnings, and ASS entry box component.#219

Merged
reid23 merged 18 commits into
mainfrom
dev
Jun 11, 2026
Merged

Match edit stability, schedule warnings, and ASS entry box component.#219
reid23 merged 18 commits into
mainfrom
dev

Conversation

@reid23

@reid23 reid23 commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Summary

primarily pre-MHO changes working towards #199. doesn't do everything, but kind of does the bare minimum to make sure MHO goes well:

  • proper error handling
  • better warnings about common issues
  • stabilize topological sort

also includes the smart ASS entry box

What changed

See #217

  • creating, editing, and deleting matches now never fails (previously schedule issues would lead to opaque "server error" messages and sometimes the changes would go through anyway and sometimes they wouldn't)
    • changing match names is prohibited. yes this is kinda a bandaid fix but it is better than nothing, and deleting and re-creating a match isn't the end of the world.
  • no more cyclic changes from recomputing the schedule by switching topological sort tiebreaker metric from nominal_start_time (which changes dynamically) to scheduled_start_time (which is set without knowledge of the true match start/end times)

some of the docs have been updated but not as much as I had hoped. I just really want to get this out before MHO.

see #200

  • autocomplete that works for ASS
  • shows more info for matches (ie, teams, field)
  • type checking for ASS
  • error messages for simple ASS errors
  • new component that manages all this
  • removed cons because im not dealing with implementing that properly
  • added quote and the standard shorthand so people can construct lists

Migration impact

 - Alembic revisions added: 0009
 - Run `just db-backup && just db-migrate` before deploy.

very simple. copies existing info from nominal_start_time. safe to revert.

Test plan

  • just test passes locally
  • just coverage-check passes locally, or CI coverage is sufficient
  • Manual verification:
    • no data lost when deploying to staging
    • tested a few different schedule scenarios; worked as expected. See the dev PR.
    • tested all ass functions individually and type checking through chains that included everything

Linked issues

Closes #217
Closes #200
Refs #199

Pre-review checklist

  • Title prefixed with one of [Feature], [Bugfix], [Refactor], [Documentation].
  • Branch name follows category/name (feat/..., bugfix/..., refactor/...).
  • Targeting dev, not main (unless this is a release PR).
  • just lint and just format are clean.
  • Tests added or updated for the new behavior.
  • If a new module was added under app/: corresponding app/<area>/README.md and docs/api/*.rst are updated.
  • If developer workflow changes: README.md, CONTRIBUTING.md, or TESTING.md updated.
  • No merge conflicts with the base branch.

Reid Dye and others added 18 commits June 4, 2026 18:58
… its confusing me during pride month. swapped cons for quote since we dont have linked lists or cons cells and cons was not doing what it advertised.
[Feature] ASS entry box component
…initial scheduled start time' attribute (different from nominal start) (sorry yes these names are horrendously easy to confuse)
@CoolCatMona

Copy link
Copy Markdown
Collaborator

looking forward to the rollout day before the tournament : )

@reid23 reid23 merged commit 8910518 into main Jun 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pre-MHO immediate schedule edit fixes ASS Entry UI fixing

2 participants