Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
caden-kline
force-pushed
the
ld-preload-symbol
branch
from
29ab296 to
46046a3
Compare
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
caden-kline
force-pushed
the
ld-preload-symbol
branch
from
46046a3 to
a6b2bff
Compare
caden-kline
force-pushed
the
ld-preload-symbol
branch
from
a6b2bff to
921ed75
Compare
zestrada
reviewed
Jan 23, 2025
| During static analysis the LibrarySymbols class collected | ||
| key->value mappings from libraries exporting some common nvram | ||
| defaults symbols ("Nvrams", "router_defaults") - add these to our | ||
| nvram config if we have any. |
Contributor
Author
There was a problem hiding this comment.
yeah I thought I had
zestrada
reviewed
Jan 23, 2025
| for file in sources.keys(): | ||
| if file in self.linker_paths.keys(): | ||
| self.linker_paths.pop(file) | ||
| if not ("_dl_preload" in sources[file] or "handle_ld_preload" in sources[file]): |
Member
There was a problem hiding this comment.
Not sure if this list is exhaustive... we'll do some experiments to see what we have in the corpus?
zestrada
reviewed
Jan 23, 2025
|
|
||
| logger.debug(f"Identified architecture: {best}") | ||
| return best | ||
| return (best, loaders) |
Member
There was a problem hiding this comment.
Should we consider a dict here?
Contributor
Author
There was a problem hiding this comment.
It depends on whether we will extract more info as time goes on. As it is I special cased the dumping process to avoid dumping loaders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#496 Identifies all linkers in a given system and ensures that they either have the preload symbol or are glibc.