Conversation
…ers within ISF structures This commit introduces functionality to parse the `return_type` and `parameters` from the ISF type definitions of function pointers (e.g. `proc_open` inside struct jump tables). Changes: - Added `.signature` property to `Ptr` returning a `VtypeFunction` object to expose function signatures natively. - Updated `points_to_type_name` to return `"function"` rather than `"void"` for clearer debugging and introspection. - Implemented full backwards compatibility to gracefully support older ISFs (defaulting missing function details to a `void` return type and empty parameters). - Added comprehensive unit tests targeting structure-bound function pointers.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ers within ISF structures This commit introduces functionality to parse the `return_type` and `parameters` from the ISF type definitions of function pointers (e.g. `proc_open` inside struct jump tables). Changes: - Added `.signature` property to `Ptr` returning a `VtypeFunction` object to expose function signatures natively. - Updated `points_to_type_name` to return `"function"` rather than `"void"` for clearer debugging and introspection. - Implemented full backwards compatibility to gracefully support older ISFs (defaulting missing function details to a `void` return type and empty parameters). - Added comprehensive unit tests targeting structure-bound function pointers, including E2E C compilation validation.
…ers within ISF structures This commit introduces functionality to parse the `return_type` and `parameters` from the ISF type definitions of function pointers (e.g. `proc_open` inside struct jump tables). Changes: - Added `.signature` property to `Ptr` returning a `VtypeFunction` object to expose function signatures natively. - Updated `points_to_type_name` to return `"function"` rather than `"void"` for clearer debugging and introspection. - Implemented full backwards compatibility to gracefully support older ISFs (defaulting missing function details to a `void` return type and empty parameters). - Added comprehensive unit tests targeting structure-bound function pointers, including E2E C compilation validation. - Fixed E2E test assertions to accurately query `type_info` and `return_type_info` dicts instead of relying on the un-resolved `name` attribute of a potential dictionary returned by `.type` or `.return_type`.
…ers within ISF structures This commit introduces functionality to parse the `return_type` and `parameters` from the ISF type definitions of function pointers (e.g. `proc_open` inside struct jump tables). Changes: - Added `.signature` property to `Ptr` returning a `VtypeFunction` object to expose function signatures natively. - Updated `points_to_type_name` to return `"function"` rather than `"void"` for clearer debugging and introspection. - Implemented full backwards compatibility to gracefully support older ISFs (defaulting missing function details to a `void` return type and empty parameters). - Added comprehensive unit tests targeting structure-bound function pointers, including E2E C compilation validation. - Fixed E2E test assertions to accurately query `type_info` and `return_type_info` dicts instead of relying on the un-resolved `name` attribute of a potential dictionary returned by `.type` or `.return_type`. - Added skip condition in E2E tests for older `dwarf2json` executables that omit signature extraction.
… typedef resolution - Updated assertions in `test_e2e_struct_function_pointer_member` to accept base types (`long long int`, `long int`, `long unsigned int`) in addition to their typedef aliases (`loff_t`, `long`, `unsigned long`), resolving test failures across different versions of GCC/Clang and architectures.
lacraig2
force-pushed
the
fix-struct-function-pointers-1064982705633731633
branch
from
16834ac to
65e32f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted and exposed full function signatures from function pointers within ISF structures. Added
signatureproperty toPtrand updatedpoints_to_type_name. Handled backwards compatibility with legacy ISF files and included new test coverage.PR created automatically by Jules for task 1064982705633731633 started by @lacraig2