Make ClosureHookPoint only generic over lifetimes, not types#23
Merged
Conversation
Closure types can't be expressed explicitly, which made it very difficult to use the types previously returned by the closure hooks in anything other than the simplest ways. This encapsulates them behind a dyn bound so that callers only need to specify `ClosureHookPoint`.
Owner
|
Thanks to the addition. I'll upgrade the minor version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closure types can't be expressed explicitly, which made it very difficult to use the types previously returned by the closure hooks in anything other than the simplest ways. This encapsulates them behind a dyn bound so that callers only need to specify
ClosureHookPoint.(This is technically a breaking change, although I doubt anyone other than me is using these APIs yet.)