define x86/x64 features#19
Merged
Merged
Conversation
Closed
Owner
|
Does the cargo doc work? I didn't separate the x64 and x86 guards by architecture because it would be impossible to generate a document that includes both x86 and x64 modules. |
Contributor
Author
|
AFAIK it would build doc for both as per both are set default, but if we switch toolchain from nightly-x86_64-pc-windows-msvc to nightly-i686-pc-windows-msvc it would fail to build with same build error as described into mentioned issue. |
Contributor
Author
|
@regomne any news? |
Owner
|
A bit busy, I'll test it asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18
Workaround, if we specify only x86 feature of library we can easily skip x64 win64 requirements during i686-pc-msvc build.
I kept both turned ON by default, as it used to be.