Allow symlinks pointing outside the vault#692
Open
alexbrasetvik wants to merge 71 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
Thanks a lot for Tolaria. I'm experimenting with using it in a way where we federate knowledge bases from multiple different git repositories. To achieve that, at least for now, I'm currently symlinking across them. I opened this feature request for federated/multi-vault for more first class support for that approach.
Tolaria currently rejects symlinks, since
canonicalize()resolves them to being outside the vault root. I imagine that's a security feature, so MCP tools cannot reach outside the vault, which sounds pretty reasonable.This PR allows symlinks inside the vault to point outside it, but rejects any attempt at using "..".
This was Claude assisted, and though I'm not experienced with the tech stack, it looks reasonable to me.