✨ Allow resetting ack when calling ping()#19
Merged
alecgibson merged 1 commit intomainfrom Feb 18, 2025
Merged
Conversation
At the moment, when calling:
```js
queue.ping({resetTries: true})
```
The tries are reset as if the job hasn't been picked up, but the `ack`
is left as-is.
This isn't necessarily problematic in the operation of the queue, but it
does mean that the pinged job will still show up as [in-flight][1].
This change adds an optional `resetAck` flag, which will also unset the
`ack`, and means that the job can be marked as not in-flight, as if it
has never been picked up.
[1]: https://github.com/reedsy/mongodb-queue/blob/6133fc9367f4fce719e36d8866841d531e956b6b/mongodb-queue.ts#L262
dawidreedsy
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, when calling:
The tries are reset as if the job hasn't been picked up, but the
ackis left as-is.This isn't necessarily problematic in the operation of the queue, but it does mean that the pinged job will still show up as in-flight.
This change adds an optional
resetAckflag, which will also unset theack, and means that the job can be marked as not in-flight, as if it has never been picked up.