feat(mkb): Add option to disable Ctrl+Scroll zoom in fullscreen#908
Open
huneyoliv wants to merge 2 commits into
Open
feat(mkb): Add option to disable Ctrl+Scroll zoom in fullscreen#908huneyoliv wants to merge 2 commits into
huneyoliv wants to merge 2 commits into
Conversation
Owner
|
thank you. I'll take a look later. |
Author
|
Don't add my PR now. I found a bug in specifics situations I will fix that. |
|
hi |
Author
|
Hi bro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new Mouse & Keyboard preference (
StreamPref.MKB_DISABLE_ZOOM) to optionally block theCtrl+Scrollbrowser zoom behavior when playing in fullscreen, preventing accidental browser scaling during intense gameplay.Since it's implemented as a StreamPref, it natively supports being toggled globally or per-game in the Stream Settings overlay.
Changes made
MKB_DISABLE_ZOOMto pref-keys.ts and stream-settings-storage.tswheelevent listeners that passively capturee.ctrlKeyinside index.ts only when fullscreen is active.Testing
Ctrl+Scrollzoom is successfully blocked in fullscreen and allowed normally when windowed or when the option is disabled.(Note: I've read the README about PR rules, but this is a very helpful QoL/Accessibility feature to prevent zooming issues for Mouse/Keyboard players on PC browsers without needing external extensions. Please consider it!)