frontend: fix knowledge base secrets missing template wrapper #2135
+101
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The knowledge base create form was sending secret values without the
${secrets.} wrapper, causing the backend to receive raw secret IDs
instead of properly formatted secret references.
All SecretSelector onChange handlers now wrap the selected secret ID
with formatSecretTemplate() before storing in form state.
Affected fields:
- postgres_dsn (vector database)
- openaiApiKey (embedding generator)
- cohereApiKey (embedding generator)
- redpandaPassword (indexer)
- rerankerApiKey (retrieval)
birdayz
force-pushed
the
jb/fix-kb-secrets-wrapper
branch
from
65118b5 to
63d9ddd
Compare
malinskibeniamin
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix regression where knowledge base create form sends secrets without the
${secrets.}wrapper.Why
Secrets were being sent as raw IDs (e.g.,
OPENAI_API_KEY) instead of properly formatted references (${secrets.OPENAI_API_KEY}), breaking secret resolution on the backend.Implementation details
All SecretSelector onChange handlers in the KB create form now wrap the selected secret ID with
formatSecretTemplate()before storing in form state. The detail/edit page already had this fix - regression was isolated to the create flow.Affected fields:
postgres_dsn(vector-database-section.tsx)openaiApiKey(embedding-generator-section.tsx)cohereApiKey(embedding-generator-section.tsx)redpandaPassword(indexer-section.tsx)rerankerApiKey(retrieval-section.tsx)