frontend: move to new sidebar #2130
Closed
+1,254
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinskibeniamin
requested review from
Mateoc,
c-julin,
sago2k8 and
yougotashovel
and removed request for
a team
Changes Made:
1. SidebarLogo
- Added aria-label="Go to Overview" to the link
- Set alt="" on decorative image (aria-label describes the action)
2. SidebarCollapseToggle
- Added aria-expanded to indicate sidebar state
- Added aria-label describing the action
- Added aria-hidden="true" to icons
3. UserProfileNew
- Added aria-label to dropdown trigger (User menu for {name})
- Added aria-hidden="true" to all decorative icons (ChevronUp, Settings, LogOut)
- Set alt="" on avatar image (aria-label on button describes context)
4. SidebarNavItem
- Added aria-current="page" for active navigation items
- Added aria-disabled for disabled items
- Added aria-hidden="true" to nav icons
- Changed disabled item container from <div> to <span role="link"> for better semantics
5. SidebarNavigation
- Wrapped menu in <nav aria-label="Main navigation"> landmark
c-julin
approved these changes
Jan 13, 2026
graham-rp
reviewed
Jan 13, 2026
Contributor
graham-rp
left a comment
graham-rp
left a comment
There was a problem hiding this comment.
This seems like a lot to add without any additional test coverage. sidebar.tsx is also really hard to read
| // c could be null, because the call to /api/console/endpoints failed or is not responded yet, | ||
| // in that case those endpoints should be considered unsupported | ||
| switch (f.endpoint) { | ||
| case Feature.SchemaRegistryACLApi.endpoint: |
Contributor
Author
There was a problem hiding this comment.
This actually meant we are able to accidentally let the user click into a sidebar item before we realized that 1 of the endpoints was failing, meaning the feature should be disabled because that service is not responsive.
Contributor
Author
|
Closing this in favor of #2132 |
Contributor
Author
I agree. I fixed it in #2132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for:
Summary
Introduces a new modern sidebar for self-hosted Console, replacing the legacy Chakra UI implementation with Tailwind/shadcn components.
Changes
BEFORE
AFTER