Always build with enable-dex when installing#1
Open
xandfury wants to merge 1 commit intorednaga:masterfrom
Open
Always build with enable-dex when installing#1xandfury wants to merge 1 commit intorednaga:masterfrom
xandfury wants to merge 1 commit intorednaga:masterfrom
Conversation
Member
|
The goal of this repo is to make minimal changes which will be accepted into the official yara-python repo. I can't accept this PR since the changes are highly specific to APKiD. |
Member
|
I also don't know what these changes are for since the APKiD instructions work fine. Maybe a description would help other people who might want to use this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation : Trying to simplify installation of APKiD. This should allow the
yarafork to be listed as part of the requirements.