Skip to content

DOC-6755 fixed incorrect Run in Browser link for PHP#3523

Merged
andy-stark-redis merged 1 commit into
mainfrom
DOC-6755-add-array-data-type-examples
Jun 18, 2026
Merged

DOC-6755 fixed incorrect Run in Browser link for PHP#3523
andy-stark-redis merged 1 commit into
mainfrom
DOC-6755-add-array-data-type-examples

Conversation

@andy-stark-redis

@andy-stark-redis andy-stark-redis commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Documentation example metadata only; no runtime or product behavior changes.

Overview
Fixes the incorrect Run in Browser target for PHP on the arrays tutorial (DOC-6755).

In DtArraysTest.php, removes the // BINDER_ID php-arrays-tutorial marker so the example follows the same pattern as the other arrays_tutorial clients, which use only // EXAMPLE: arrays_tutorial for doc/runner binding. The stray binder id was pointing the browser runner at the wrong asset.

Also wraps the PHPUnit TestCase import in REMOVE_START / REMOVE_END so it is stripped from published snippets like the extends TestCase boilerplate already was.

Reviewed by Cursor Bugbot for commit e77ae1d. Bugbot is set up for automated code reviews on this repo. Configure here.

@andy-stark-redis andy-stark-redis requested a review from a team June 18, 2026 08:35
@andy-stark-redis andy-stark-redis self-assigned this Jun 18, 2026
@andy-stark-redis andy-stark-redis added the clients Client library docs label Jun 18, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

DOC-6755

@jit-ci

jit-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@dwdougherty dwdougherty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andy-stark-redis

Copy link
Copy Markdown
Contributor Author

Thanks @dwdougherty !

@andy-stark-redis andy-stark-redis merged commit 0303aff into main Jun 18, 2026
74 of 75 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-6755-add-array-data-type-examples branch June 18, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clients Client library docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants