Conversation
Contributor
Contributor
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
andy-stark-redis
approved these changes
Apr 1, 2026
andy-stark-redis
left a comment
Contributor
There was a problem hiding this comment.
One minor suggestion that might improve the clarity of the lists a bit, but otherwise language and links LGTM.
yoavredis
reviewed
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Markdown documentation only; no application, API, or infrastructure code changes.
Overview
Expands the Create CA-signed certificates section in
create-certificates.mdfrom short guidelines and a minimal OpenSSL example into an end-to-end operator guide.Certificate requirements are consolidated into explicit rules: both TLS Web Server and TLS Web Client authentication in extended key usage (with a warning that server-only templates break TLS), required SAN DNS patterns for cluster FQDNs, key usage, SHA-256/512, RSA key size, and chain ordering in PEM files.
New procedural content covers OpenSSL (sample
redis-cert.cnf, key/CSR generation, CSR verification, CA submission, chain assembly), Windows AD Certificate Services (custom template with client+server auth,certreqflow, PFX export and PEM conversion), pre-upload validation (opensslchecks for EKU, SAN, chain, key match), install steps (chmod/chownandrladmin cluster certificate setwith a cert-name table), and troubleshooting forSSLV3_ALERT_UNSUPPORTED_CERTIFICATE,CERTIFICATE_VERIFY_FAILED, key mismatch, and missing SANs.The older split server/client certificate guidelines and the brief standalone Create certificates OpenSSL-only steps are largely replaced by this structure.
Reviewed by Cursor Bugbot for commit 263ba8f. Bugbot is set up for automated code reviews on this repo. Configure here.