Open
Conversation
…7632-rdi-api-v2-core-initial
…e-initial RI-7632: initial implementation of v2 api client
…2-rdi-api-v2-statistics-rework # Conflicts: # redisinsight/ui/src/pages/rdi/statistics/status/styles.ts # redisinsight/ui/src/pages/rdi/statistics/styles.ts
…tics-rework RI-7632: rework API for RDI statistics
* RI-7632: rework statistics for api/v2 client * capitalize enum * change component name type
# Conflicts: # redisinsight/ui/src/pages/rdi/statistics/clients/Clients.tsx # redisinsight/ui/src/pages/rdi/statistics/data-streams/DataStreams.tsx # redisinsight/ui/src/pages/rdi/statistics/processing-performance/ProcessingPerformance.tsx # redisinsight/ui/src/pages/rdi/statistics/target-connections/TargetConnections.spec.tsx # redisinsight/ui/src/pages/rdi/statistics/target-connections/TargetConnections.tsx
* RI-7632: rework statistics for api/v2 client * RI-7632: RDI API V2 Status Rework * RI7632: fix typer * RI-7632: fix tests after removing debug v1 get status call * consider deploy loading to disable action buttons * change icon for stopped status * consider reset/deploy on action buttons * fix integration tests * address PR comments * remove leftovers after merge * fix section after redis-ui update * fix tables
Contributor
Code Coverage - Backend unit tests
Test suite run success3153 tests passing in 297 suites. Report generated by 🧪jest coverage report action from 673f7fb |
Contributor
Code Coverage - Frontend unit tests
Test suite run success5628 tests passing in 707 suites. Report generated by 🧪jest coverage report action from 673f7fb |
* RI-7632: rework statistics for api/v2 client * RI-7632: RDI API V2 Status Rework * RI7632: fix typer * RI-7632: add components statistics * add back removed tests by mistake
Contributor
Code Coverage - Integration Tests
|
ArtemHoruzhenko
requested review from
DimoHG,
KrumTy,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
redisinsight/api/src/modules/rdi/providers/rdi.client.factory.ts
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/mocks/factories/rdi/RdiStatistics.factory.ts
Outdated
Show resolved
Hide resolved
KrumTy
previously approved these changes
Feb 4, 2026
Contributor
KrumTy
left a comment
KrumTy
left a comment
There was a problem hiding this comment.
Overall LGTM, just some minor suggestions that now I see AI has also caught apparently:
- Change let to const for variables that aren't reassigned - Move v2 client instantiation inside try block to avoid waste on fallback - Add Logger for version detection fallback visibility - Remove unused StatisticsColumnFactory from test factories References: #RI-7632
KrumTy
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for RDI API v2 with automatic version detection and graceful fallback to v1.
Key Changes
ApiV2RdiClientthat extends v1 client with automatic version detectionRdiPipelineStatusmodel with proper Start/Stop button logic for v2 statusesIncluded PRs
Testing
All changes were reviewed and tested in individual PRs before merging to feature branch.
Note
Medium Risk
Introduces a new API v2 code path with runtime version detection and reshapes status/statistics responses, which can affect UI rendering and pipeline control behavior if mappings or transformers are wrong.
Overview
Adds RDI API v2 support by introducing
ApiV2RdiClientand updatingRdiClientFactoryto probeapi/v2/info, then auto-select a pipeline and fall back to v1 when v2 isn’t available.Reworks pipeline status and statistics to return unified, typed models: v1 status responses are transformed into
RdiPipelineStatus, statistics now return asections[]array (table/blocks/info) produced by new v1/v2 transformers (including a v2-only Component Status section) and shared column-generation utilities.Updates controllers/services/tests to drop the
sectionsquery param, addgetVersion()to the client contract, adjust RDI version discovery, and refactors the UI to render statistics dynamically fromsections[]plus updated start/stop button logic for v2 statuses.Written by Cursor Bugbot for commit 673f7fb. This will update automatically on new commits. Configure here.