Open
Conversation
…ency Standardize `themes` usage in `pluginsThemeContext` and `themeContext`, replacing `themesDefault` and `themesRebrand`. Streamline code readability and align import patterns.
…emeContext` for consistency
…sage - Introduced a new `theme.ts` file to consolidate theme-related imports and exports. - Updated `themeContext` and `pluginsThemeContext` to utilize the centralized theme utilities, enhancing code clarity and reducing duplication.
Contributor
Code Coverage - Frontend unit tests
Test suite run success5545 tests passing in 707 suites. Report generated by 🧪jest coverage report action from b8f2192 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate theme imports from
themesDefaulttothemesRebrandacross both theme contexts:themeContext.tsxto usethemesRebrandfor the main apppluginsThemeContext.tsxto usethemesRebrandfor pluginsthemesfor consistent destructuring patternTesting
themesDefaultandthemesRebrandyarn dev:desktopNote
Switches theming to the rebranded set and centralizes theme imports.
uiSrc/styles/themeto re-exportCommonStylesandthemesRebrandasthemeLight/themeDark, and to host one-time CSS importsthemeContext.tsxandpluginsThemeContext.tsxto consumeCommonStyles,themeLight, andthemeDarkfrom the new module; removes direct CSS importscomponents/base/theme/index.tsWritten by Cursor Bugbot for commit b8f2192. This will update automatically on new commits. Configure here.