chore: improve logic: don't imply failures if there are none; don't pass the build if there are failures (RHIDP-9067) #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass the build if there are failures (RHIDP-9067) Signed-off-by: Nick Boldt <nboldt@redhat.com>
nickboldt
changed the title
… get console output even if the script fails Signed-off-by: Nick Boldt <nboldt@redhat.com>
Contributor
|
I agree with that it is better to not to have tag, while have an empty tag, i think it would be better to merge this |
polasudo
previously approved these changes
Dec 18, 2025
… followup logging steps to still run even if the export fails Signed-off-by: Nick Boldt <nboldt@redhat.com>
|
polasudo
approved these changes
Dec 18, 2025
Contributor
polasudo
left a comment
polasudo
left a comment
There was a problem hiding this comment.
it helps with not having silence failures also
Contributor
|
/lgtm |
Contributor
|
/approve |
polasudo
approved these changes
Dec 18, 2025
davidfestal
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chore: improve logic: don't imply failures if there are none; don't pass the build if there are failures (RHIDP-9067)
Signed-off-by: Nick Boldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
without this change we have silent failures in Konflux that mask export problems and result in empty OCI artifacts
See:
How to test this PR?
once merged we can see if workflows fail faster, eg., https://github.com/redhat-developer/rhdh-plugin-export-utils/blob/main/.github/workflows/export-dynamic.yaml#L276-L279
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.