chore: Exclude testdata from SonarCloud analysis

[rm3l]

Description

Exclude testdata from SonarCloud analysis

Which issue(s) does this PR fix or relate to

Fixes the warnings reported in #2067 (comment)

PR acceptance criteria

• Tests
• Documentation

How to test changes / Special notes to the reviewer

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nickboldt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhdh-qodo-merge]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🔒 No security concerns identified

⚡ Recommended focus areas for review Scope Overlap Adding **/testdata/**/* to both sonar.test.inclusions and sonar.exclusions may create ambiguous classification or effectively exclude those files from both source and test scopes depending on SonarCloud precedence. Confirm the intended outcome (fully excluded from analysis vs treated as tests) and adjust patterns accordingly. sonar.test.inclusions = tests/**/*, integration_tests/**/*, **/*_test.go, **/testdata/**/* # Exclude test subdirectories from source scope sonar.exclusions = tests/**/*, integration_tests/**/*, **/*_test.go, **/zz_generated.deepcopy.go, **/testdata/**/* Exclusion Breadth The glob **/testdata/**/* excludes any directory named testdata anywhere in the repo. Validate that this won’t hide relevant non-test fixtures or embedded assets that should still be analyzed, and consider narrowing the pattern if needed (e.g., only under specific modules). sonar.test.inclusions = tests/**/*, integration_tests/**/*, **/*_test.go, **/testdata/**/* # Exclude test subdirectories from source scope sonar.exclusions = tests/**/*, integration_tests/**/*, **/*_test.go, **/zz_generated.deepcopy.go, **/testdata/**/*

📄 References redhat-developer/rhdh-operator/Makefile [210-211] redhat-developer/rhdh-operator/best_practices.md [116-165] redhat-developer/rhdh-operator/docs/developer.md [20-31] redhat-developer/rhdh-operator/integration_tests/README.md [1-46] redhat-developer/rhdh-operator/tests/e2e/README.md [1-12] redhat-developer/rhdh-operator/docs/developer.md [32-55] redhat-developer/rhdh-operator/README.md [78-84] redhat-developer/rhdh-operator/tests/e2e/README.md [112-122]

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rhdh-qodo-merge]

PR Type

Enhancement

---

Description

• Exclude testdata directories from SonarCloud analysis

• Add testdata to both test inclusions and exclusions patterns

• Prevents SonarCloud warnings from test data files

---

File Walkthrough

	Relevant files
Configuration changes	.sonarcloud.properties Add testdata exclusion patterns to SonarCloud config          .sonarcloud.properties Added **/testdata/**/* pattern to sonar.test.inclusions to include testdata in test scope Added **/testdata/**/* pattern to sonar.exclusions to exclude testdata from source scope Prevents SonarCloud from analyzing test data files as production code +2/-2

---

[rhdh-qodo-merge]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Remove contradictory test data inclusion rule Remove the /testdata//* pattern from sonar.test.inclusions to resolve the contradiction of also having it in sonar.exclusions. .sonarcloud.properties [6] -sonar.test.inclusions = tests/**/*, integration_tests/**/*, **/*_test.go, **/testdata/**/* +sonar.test.inclusions = tests/**/*, integration_tests/**/*, **/*_test.go Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies a contradictory configuration where testdata is both included as a test source and excluded from analysis, which improves configuration clarity.	Low
More

[rm3l]

/cc @gazarenkov

[rm3l]

Merging to see the results in SonarCloud.