-
Notifications
You must be signed in to change notification settings - Fork 8
fix: yarn.lock for frontend plugins #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
6cc96e2 to
139068e
Compare
|
had a chat today with Kim and Rogue today to discuss how to move forward and the TL;DR is for the next 6mo:
|
139068e to
a561c53
Compare
a561c53 to
9701bbf
Compare
This change updates the CLI's frontend script to create a yarn.lock based on the exported plugin package in a similar fashion to backend plugins. This makes the exported plugin package for frontend plugins more consistent with backend plugins and allows another means for security scanners to inspect the plugin's dependencies. This change also moves functions that are shared between the backend and frontend commands into a shared utils file so it's more obvious which functions are common to each command.
9701bbf to
920f14e
Compare
|
|
So on the remaining sonarqube complaints:
|



This change updates the CLI's frontend script to create a yarn.lock based on the exported plugin package in a similar fashion to backend plugins, with the difference being the resulting node_modules folder is removed afterwards. This makes the exported plugin package for frontend plugins more consistent with backend plugins and allows another means for security scanners to inspect the plugin's dependencies.
Issue: https://issues.redhat.com/browse/RHIDP-11050