Skip to content

Conversation

@akhilnittala
Copy link
Contributor

@akhilnittala akhilnittala commented Feb 3, 2026

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Identifies Roles and RoleBindings associated with namespace-scoped Argo CD instances and restores any missing labels to ensure correct resource tracking and cleanup.
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-8964
Fixes #?
https://issues.redhat.com/browse/GITOPS-8964
Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:
First reproduce the issue based on the steps mentioned in the jira https://issues.redhat.com/browse/GITOPS-8537
Install gitops operator with changes and verify the resources which are not cleanedup as per above step.

Signed-off-by: akhil nittala <nakhil@redhat.com>
@openshift-ci openshift-ci bot requested review from jannfis and keithchong February 3, 2026 13:04
@svghadi
Copy link
Member

svghadi commented Feb 3, 2026

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 3, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

@akhilnittala: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-e2e 4cec4fa link true /test v4.14-e2e
ci/prow/v4.14-kuttl-parallel 4cec4fa link true /test v4.14-kuttl-parallel
ci/prow/v4.14-kuttl-sequential 4cec4fa link true /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants