GOLDENG 92: Allow all users to view/edit snoovatars#72
GOLDENG 92: Allow all users to view/edit snoovatars#72helen-tang wants to merge 2 commits intomasterfrom
Conversation
| ) | ||
| def GET_snoovatar(self, vuser): | ||
| if not vuser or vuser._deleted or not vuser.gold: | ||
| if not vuser or vuser._deleted: |
There was a problem hiding this comment.
should we put this behind a feature flag?
| @@ -46,7 +46,7 @@ def GET_partners(self): | |||
| vuser=VExistingUname("username"), | |||
| ) | |||
| def GET_snoovatar(self, vuser): | |||
There was a problem hiding this comment.
There are a couple more checks that affect snoovatars due to the VGold validator on some of the endpoints below
There was a problem hiding this comment.
can't save my snoovatar cuz this https://github.com/reddit/reddit-plugin-gold/blob/master/reddit_gold/controllers.py#L82
|
The r2 link is still hidden behind |
|
💅 A few things |
|
this is what Melissa was talking about: https://github.com/reddit/reddit-public/blob/master/r2/r2/templates/profilebar.html#L117-L129 |
|
@jonowar @MelissaCole Yep! I have a separate PR incoming for R2! Just got caught up in some Snoosweek things so I haven't pushed it up. |
|
💅 |
helen-tang
changed the title
3 participants
This PR addresses: https://reddit.atlassian.net/browse/GOLDENG-92
Originally, users who were not gold users were not able to view their snoovatars. We now want to open that up to all users.
UPDATE
This PR also removes this dialogue from the Snoovatar creation page as it's no longer relevant: