Feature/fix wrong type 4ps module#456
Merged
Merged
Conversation
v3.13.0 release
v3.14.0 release
* Location of connection must be dynamic (#432) * make location dynamic * Update main.tf * Update variables.tf * Update main.tf * Added -Force param to Logic App Standard to bypass confict errors on local AB#21762 * Allow Access Policy name to be speficied explicitely AB#21752 * Add variable to configure logging extent (#435) * Add variable to configure logging extent * Update variables.tf * Update main.tf * format * Add dimension and frequency configuration (#437) * Add dimention and frequncy config * format * fix null dimension access * allow list of dimensions * Added optional diagnostic settings for Standard Logic Apps * Adding role validation into api policy * Api management support multiple roles validation AB#22184 (#440) * Api management support multiple roles validation * fix fmt * adding service principal role assignments * resolving PR comments * fix formating * feat: Apply diagnostic settings changes once the deployment is finished (#441) * feat: Apply diagnostic settings changes once the deployment is finished * Added comment * Upgraded default TLS on SB (since older are going to be deprecated) * Update modules/azure/service_bus_public/variables.tf Co-authored-by: tom-reinders <tom-reinders@users.noreply.github.com> * Adding optional setting for diagnostic categories * fix TF formating * Adding property to enable/disable sftp on storage account * feat: Added Standard Logic App with Managed Identity and IP restriction (for HTTP trigger) * Merged Standard Logic App modules into a single one * Omit MICROSOFT_PROVIDER_AUTHENTICATION_SECRET when not applicable * Reverse condition * Updated appsettings configuration * fix: Removed validation for optional module AB#23089 (#446) * added app_scale_limit into windows azure function module * update of app_scale_limit to leverage null or not being set * update the condition and remove comment * app_scale_limit set default to 0 * feat: Enable option to configure runtime_scale_monitoring_enabled * feat: Allow APIM API bytes_to_log to be specified * Updated terraform providers to their latest minor versions (#450) * Updated terraform providers to their latest minor versions * Fixed azurerm version for service_plan * reverted elastic/ec version * Updated TF providers: Merging into develop (#451) * Updated terraform providers to their latest minor versions * Fixed azurerm version for service_plan * reverted elastic/ec version * Update main.tf deprecated application_id -> client_id * Update main.tf * Added separate frontdoor firewall policy, extracted classic. * Fixed managed_rule action and details link * Added support for Front Door Standard * Fixed origins parameter reference * Added https_redirect_enabled=false * Removed link_to_default_domain initialization * FD: Updated optional variables * Updated FD templates according to migrated FD example * Fixed variable property name. Aligned spaces * FD: Fixed variable interpolation. Initialized necessary property * FD: Set link_to_default_domain to false * Temporarily set cloudfare records as data source * CF: added type filter * CF: Temporarily commented outputs * Update README.md * Update README.md * FD: introduced FD security policy * Reverted main and outputs of cloudflare dns records * Replaced some deprecated properties * CF: fixed outputs * Fixed setting application_id for app password * Added temporary output of API policy XML content * Reverted auth v2 logic for function app * Creating an API will now always create an SP * Fixed syntax error * Fixed tenant auth settings URL * Set use_existing to true for API SP --------- Co-authored-by: ArtiomMatiom <89966532+ArtiomMatiom@users.noreply.github.com> Co-authored-by: Michal Pipal <m.pipal@recognize.nl> Co-authored-by: tom-reinders <tom-reinders@users.noreply.github.com> Co-authored-by: ArtiomMatiom <a.matievschi@recognize.nl> Co-authored-by: Patrik Kovacs <74901276+patrik-pa4k@users.noreply.github.com> Co-authored-by: Michal Pipal <73311540+pipalmic@users.noreply.github.com> Co-authored-by: zjanura <zdenek.janura@isonsoft.cz>
… apps Replace dynamic enabled_log blocks (based on data.azurerm_monitor_diagnostic_categories) with static category_group = "allLogs" to prevent "Provider produced inconsistent final plan" errors. The issue occurs because Azure changes available diagnostic categories after a function app is modified during apply, causing a mismatch between plan and actual state. Affected modules: - function_app_linux - function_app_linux_managed_identity - function_app_windows Note: 26 other modules use the same dynamic pattern and may be affected.
Run terraform fmt -recursive to fix formatting in: - api_management_api_simple/main.tf - frontdoor_standard/main.tf - frontdoor_standard/variables.tf - logic_app_standard/main.tf - cloudflare/dns_records/main.tf
…nconsistent-plan fix: resolve diagnostic settings inconsistent plan error for function apps
Replace dynamic enabled_log/metric blocks with static category_group = "allLogs" in all 29 remaining modules. Removes all data.azurerm_monitor_diagnostic_categories data sources that caused "Provider produced inconsistent final plan" errors.
…ogic-apps fix: resolve diagnostic settings inconsistent plan error in all modules
kfaessen
reviewed
May 13, 2026
Contributor
kfaessen
left a comment
kfaessen
left a comment
There was a problem hiding this comment.
Een paar punten waar een beslissing over genomen moet worden - zie inline comments. Belangrijkste: filter-variabelen (categories/metrics/log_analytics_diagnostic_categories) worden in meerdere modules stilletjes genegeerd, maar staan nog in variables.tf. Daarnaast PR-titel + body dekken de scope niet en er is geen terraform plan output bijgevoegd.
| # Endpoint | ||
| resource "azurerm_cdn_frontdoor_endpoint" "fd_endpoint" { | ||
| name = var.name | ||
| name = var.name |
Contributor
There was a problem hiding this comment.
Veel formatting-only wijzigingen in dit bestand. Liever in een aparte terraform fmt PR zodat de echte diff hier (diagnostic settings) leesbaar blijft.
…ic_setting The diagnostic settings fix (#454/#455) replaced dynamic per-category filtering with static category_group = "allLogs" / category = "AllMetrics". The categories and metrics attributes on loganalytics_diagnostic_setting are no longer read in any module, so they are removed. Affected: event_grid_topic, event_hub, log_analytics_workspace, network_security_group, public_ip, service_plan, storage_account_public (blob/queue/table/file), stream_analytics, virtual_network. Breaking for external callers still passing categories/metrics.
Contributor
|
Heads-up on the base branch This PR targets As a result the diff against
Merging as-is also pulls all of Decision needed:
Both intended changes are also breaking for external module consumers ( |
…c_app_standard Same cleanup as the loganalytics_diagnostic_setting change: the diagnostic settings now use a static category_group = "allLogs", so this override variable is no longer read anywhere and is removed. Breaking for external callers still passing log_analytics_diagnostic_categories.
kfaessen
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.