Skip to content

Several fixes for docker builds and Node.js #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agjohnson merged 2 commits into from
Jun 2, 2026
Merged

Several fixes for docker builds and Node.js #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce0f13f
Update dockerfile node as well to match nodejs upgrade to 24.16
agjohnson Jun 2, 2026
f930450
Revert JSON comment in package.json
agjohnson Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.addons
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:22.16.0
FROM node:24.16.0
COPY package-lock.json /usr/src/app/checkouts/addons/
COPY package.json /usr/src/app/checkouts/addons/
WORKDIR /usr/src/app/checkouts/addons/
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.webpack
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:22.11
FROM node:24.16.0
COPY package-lock.json /usr/src/app/checkouts/ext-theme/
COPY package.json /usr/src/app/checkouts/ext-theme/
WORKDIR /usr/src/app/checkouts/ext-theme
Expand Down
1 change: 0 additions & 1 deletion packages/addons-inject/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"author": "Read the Docs, Inc",
"license": "MIT",
"dependencies": {
"//": "wrangler is pinned: 4.20+ rewrites inbound Host and X-Forwarded-Host to the value of `dev --host`, which breaks subdomain-based project resolution in El Proxito for local development",

@humitos humitos Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

"wrangler": "4.19.1"
},
"devDependencies": {
Expand Down