Skip to content

Perform AnimationEndSync commits on the React revision (#57493) #57493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Perform AnimationEndSync commits on the React revision (#57493) #57493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,8 @@ CommitStatus ShadowTree::tryCommit(
getShadowTreeCommitSourceName(commitOptions.source));

auto isReactBranch = ReactNativeFeatureFlags::enableFabricCommitBranching() &&
commitOptions.source == CommitSource::React;
(commitOptions.source == CommitSource::React ||
commitOptions.source == CommitSource::AnimationEndSync);

// Commits on the JS branch are never synchronous.
react_native_assert(!isReactBranch || !commitOptions.mountSynchronously);
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/mounting/updateMountedFlag.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ void updateMountedFlag(
// Runtime shadow node references are updated during the React revision
// commits so that JS can access layout data from the merged tree.
bool shouldUpdateRuntimeReference =
(commitSource == ShadowTreeCommitSource::React &&
((commitSource == ShadowTreeCommitSource::React ||
commitSource == ShadowTreeCommitSource::AnimationEndSync) &&
ReactNativeFeatureFlags::updateRuntimeShadowNodeReferencesOnCommit()) ||
(ReactNativeFeatureFlags::
updateRuntimeShadowNodeReferencesOnCommitThread() &&
Expand Down
Loading