Skip to content

Fix skipped post-publish jobs in release mode #57479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cipolleschi wants to merge 1 commit into from
+31 −4
Closed

Fix skipped post-publish jobs in release mode #57479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions .github/workflows/publish-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,15 @@ jobs:
post_publish:
runs-on: ubuntu-latest
needs: [determine_mode, publish_react_native]
if: needs.determine_mode.outputs.mode == 'release'
# Use always() so this job still runs in release mode even though some
# upstream jobs (e.g. build_android) are skipped and would otherwise
# poison the implicit success() gate. The explicit result checks below
# handle the real gating: only run for a successful release publish.
if: |
always() &&
needs.determine_mode.result == 'success' &&
needs.publish_react_native.result == 'success' &&
needs.determine_mode.outputs.mode == 'release'
env:
REACT_NATIVE_BOT_GITHUB_TOKEN: ${{ secrets.REACT_NATIVE_BOT_GITHUB_TOKEN }}
steps:
Expand Down Expand Up @@ -256,19 +264,38 @@ jobs:
# ─── Release-only: changelog, podfile bump, draft release ────────
generate_changelog:
needs: [determine_mode, publish_react_native]
if: needs.determine_mode.outputs.mode == 'release'
# always() + explicit result checks: run for a successful release publish
# even when skipped upstream jobs would trip the implicit success() gate.
if: |
always() &&
needs.determine_mode.result == 'success' &&
needs.publish_react_native.result == 'success' &&
needs.determine_mode.outputs.mode == 'release'
uses: ./.github/workflows/generate-changelog.yml
secrets: inherit

bump_podfile_lock:
needs: [determine_mode, publish_react_native]
if: needs.determine_mode.outputs.mode == 'release'
# always() + explicit result checks: run for a successful release publish
# even when skipped upstream jobs would trip the implicit success() gate.
if: |
always() &&
needs.determine_mode.result == 'success' &&
needs.publish_react_native.result == 'success' &&
needs.determine_mode.outputs.mode == 'release'
uses: ./.github/workflows/bump-podfile-lock.yml
secrets: inherit

create_draft_release:
needs: [determine_mode, generate_changelog, set_hermes_version]
if: needs.determine_mode.outputs.mode == 'release'
# always() + explicit result checks: run for a successful release even when
# skipped upstream jobs would trip the implicit success() gate.
if: |
always() &&
needs.determine_mode.result == 'success' &&
needs.generate_changelog.result == 'success' &&
needs.set_hermes_version.result == 'success' &&
needs.determine_mode.outputs.mode == 'release'
uses: ./.github/workflows/create-draft-release.yml
secrets: inherit
with:
Expand Down
Loading