Fix RefreshControl initial prop replay#57478
Closed
adamivancza wants to merge 1 commit into
Closed
Conversation
javache
requested changes
Jul 8, 2026
javache
left a comment
Contributor
There was a problem hiding this comment.
Comparing with _props is the right behaviour (I know, the API is pretty confusing), as that's the last props the view was configured with, and the view may have been recycled since.
If native properties are not correctly updating, that's a view recycling bug.
Author
oh indeed, I totally missed that. thx for the clarification! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #56343.
Fixes an iOS Fabric
RefreshControlregression wheretintColor,title, andtitleColorcould be skipped during initial prop replay.RCTPullToRefreshViewComponentViewwas comparing incoming props against its stored_propsinstead of theoldPropspassed intoupdateProps. In replay/deferred update paths,_propscan already match the incoming props even though the nativeUIRefreshControlhas not received those values, so the native setters were skipped.This updates the comparison to use
oldPropswhen available, with a fallback to_propsfor null initial-mount calls.Changelog:
[IOS] [FIXED] - Fix Fabric RefreshControl initial tintColor and title props not being applied on iOS
Test Plan:
Added
RCTPullToRefreshViewComponentViewTests/testUpdatePropsUsesOldPropsWhenReapplyingStoredProps.Verified the focused unit test passes: