-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Add type-test for View imperative handle methods #57465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sbalagan22
wants to merge
1
commit into
react:main
Choose a base branch
from
sbalagan22:fix/54104-view-ref-typetest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @format | ||
| */ | ||
|
|
||
| import * as React from 'react'; | ||
| import {View} from 'react-native'; | ||
|
|
||
| // A ref to a host component resolves to its imperative handle, which exposes | ||
| // the native measurement and mutation methods. `React.ComponentRef<typeof View>` | ||
| // is the pattern that resolves to that handle under both the legacy and the | ||
| // strict public types; the `View` component type itself is not the handle. | ||
| type ViewHandle = React.ComponentRef<typeof View>; | ||
|
|
||
| export function ViewImperativeHandle() { | ||
| const viewRef = React.useRef<ViewHandle>(null); | ||
| const targetRef = React.useRef<ViewHandle>(null); | ||
|
|
||
| const measure = () => { | ||
| const view = viewRef.current; | ||
| const target = targetRef.current; | ||
| if (view == null || target == null) { | ||
| return; | ||
| } | ||
|
|
||
| view.measure( | ||
| ( | ||
| x: number, | ||
| y: number, | ||
| width: number, | ||
| height: number, | ||
| pageX: number, | ||
| pageY: number, | ||
| ) => {}, | ||
| ); | ||
|
|
||
| view.measureInWindow( | ||
| (x: number, y: number, width: number, height: number) => {}, | ||
| ); | ||
|
|
||
| view.measureLayout( | ||
| target, | ||
| (left: number, top: number, width: number, height: number) => {}, | ||
| () => {}, | ||
| ); | ||
|
|
||
| view.setNativeProps({}); | ||
| }; | ||
|
|
||
| return ( | ||
| <View ref={viewRef}> | ||
| <View ref={targetRef} /> | ||
| </View> | ||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we rename this file
component-refs.tsx?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, renamed to component-refs.tsx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for taking the time to review and merge this, it was a great first contribution to React Native for me. I'd really like to keep contributing here, so if there are areas that could use help or issues you'd point a newer contributor toward, I'd be glad to pick them up. Would love to stay in touch . https://www.linkedin.com/in/sukhmanbalagan/