DELIA-70697: Ignore System App to change PowerState request if SYSTEM_SLEEP_REQUEST_KEY not configured#208
Merged
Merged
Conversation
…_SLEEP_REQUEST_KEY not configured Signed-off-by: Yuvaramachandran Gurusamy <yuvaramachandran_gurusamy@comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the platform DIAL “system” application handling so that power-state actions (sleep, togglepower) are rejected when SYSTEM_SLEEP_REQUEST_KEY is not configured, preventing unprotected power-state changes.
Changes:
- Treat missing
SYSTEM_SLEEP_REQUEST_KEYas a failure condition forsystem?action=sleep. - Treat missing
SYSTEM_SLEEP_REQUEST_KEYas a failure condition forsystem?action=togglepower. - Expand logging for key mismatch / missing configuration cases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| printf("RTDIAL: system app request to change device to sleep mode, key comparison failed: user provided '%s'\n", parsed_query["key"].c_str()); | ||
| if ((NULL == system_key) || (parsed_query["key"] != system_key)) { | ||
| if (system_key) { | ||
| printf("RTDIAL: system app request to change device to sleep mode, key comparison failed: user provided '%s', expected '%s'\n", parsed_query["key"].c_str(), system_key); |
| else { | ||
| printf("RTDIAL: system app request to change device to sleep mode, SYSTEM_SLEEP_REQUEST_KEY not set\n"); | ||
| } | ||
| return GDIAL_APP_ERROR_INTERNAL; |
| printf("RTDIAL: system app request to toggle the power state, key comparison failed: user provided '%s'\n", parsed_query["key"].c_str()); | ||
| if ((NULL == system_key) || (parsed_query["key"] != system_key)) { | ||
| if (system_key) { | ||
| printf("RTDIAL: system app request to toggle the power state, key comparison failed: user provided '%s', expected '%s'\n", parsed_query["key"].c_str(), system_key); |
| else { | ||
| printf("RTDIAL: system app request to toggle the power state, SYSTEM_SLEEP_REQUEST_KEY not set\n"); | ||
| } | ||
| return GDIAL_APP_ERROR_INTERNAL; |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
apatel859
approved these changes
Jun 25, 2026
apatel859
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DELIA-70697: Ignore System App to change PowerState request if SYSTEM_SLEEP_REQUEST_KEY not configured
Signed-off-by: Yuvaramachandran Gurusamy yuvaramachandran_gurusamy@comcast.com