RDKB-65187 - WAN Manager - Telemetry for Ignite.#213
Open
LakshminarayananShenbagaraj wants to merge 12 commits into
Open
RDKB-65187 - WAN Manager - Telemetry for Ignite.#213LakshminarayananShenbagaraj wants to merge 12 commits into
LakshminarayananShenbagaraj wants to merge 12 commits into
Conversation
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window.
Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs")
Test Procedure:
1. WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds WAN outage duration telemetry (“WAN_FAILURE_TIME_split”) intended to measure customer no-internet time using a monotonic clock, and includes several related IPv6/MAP-T and connectivity-check adjustments in the WAN interface state machine.
Changes:
- Add monotonic WAN failure timer tracking and emit telemetry when WAN service transitions back to “started”.
- Refactor IPv6 DAD/default-route readiness check to support LAN-bridge vs WAN-interface behavior (bridge-mode handling).
- Adjust IPv6 teardown / MAP-T paths, including removing some IPv6 cleanup and adding additional logging and LAN sync hooks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window.
Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs")
Test Procedure:
1. WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window.
Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs")
Test Procedure:
1. WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window.
Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs")
Test Procedure:
1. WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window.
Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs")
Test Procedure:
1. WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Comment on lines
+102
to
+106
| static void WanMgr_ResetWanFailureTimer(void) | ||
| { | ||
| gWanFailureTimerActive = false; | ||
| memset(&gWanFailureStartTime, 0, sizeof(gWanFailureStartTime)); | ||
| } |
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "secs")
Test Procedure:
WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Comment on lines
+69
to
+71
| static struct timespec gWanFailureStartTime = {0}; | ||
| static bool gWanFailureTimerActive = false; | ||
|
|
Comment on lines
+104
to
+108
| static void WanMgr_ResetWanFailureTimer(void) | ||
| { | ||
| gWanFailureTimerActive = false; | ||
| memset(&gWanFailureStartTime, 0, sizeof(gWanFailureStartTime)); | ||
| } |
Comment on lines
+1497
to
+1504
| if (pInterface->IfaceConnectionType == WAN_IFACE_CONN_TYPE_COLD_STANDBY || pInterface->IfaceType == REMOTE_IFACE) | ||
| { | ||
| WanMgr_PrintWanFailureTimeMarker(pInterface->AliasName); | ||
| } | ||
| else | ||
| { | ||
| WanMgr_ResetWanFailureTimer(); | ||
| } |
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window.
Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs")
Test Procedure:
1. WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window.
Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs")
Test Procedure:
1. WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window.
Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs")
Test Procedure:
1. WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window.
Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs")
Test Procedure:
1. WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window.
Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs")
Test Procedure:
1. WANManager should run without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:
Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_FAILURE_TIME
Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "secs")
Test Procedure:
Risks: Medium