RDKCOM-5584: RDKBDEV-3439 Prevent duplicate IPv6 assignment on brlan0 by removing redundant lan-restart sysevent handling in setUpLanPrefixIPv6().#207
Open
aprasad-97 wants to merge 1 commit into
Conversation
… redundant lan-restart sysevent handling in setUpLanPrefixIPv6(). Reason For Change: Setting the lan-restart sysevent triggers IPv6 address assignment on brlan0. Since WANManager already handles brlan0 IPv6 assignment earlier in setUpLanPrefixIPv6(), setting this sysevent again later in the function is unnecessary and causes duplicate assignment. To avoid repetition and stale configuration, the lan-restart sysevent update has been removed from the later part of the function. Risks: Low Signed-off-by: Aiswarya Prasad <aprasad@maxlinear.com>
pradeeptakdas
changed the title
|
@aprasad-97 |
S-Parthiban-Selvaraj
requested changes
Jun 15, 2026
| @@ -2134,8 +2134,6 @@ int setUpLanPrefixIPv6(DML_VIRTUAL_IFACE* pVirtIf) | |||
| /* This is for IP.Interface.1. use */ | |||
| sysevent_set(sysevent_fd, sysevent_token, COSA_DML_DHCPV6S_ADDR_SYSEVENT_NAME, globalIP, 0); | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Hello,
This lan-restart is required. We no longer set the LAn bridge address from the WAnManager.
Contributor
There was a problem hiding this comment.
Hi @aprasad-97,
Please let us know if we can close the ticket or if wew should have a call to discuss it.
Contributor
Author
There was a problem hiding this comment.
I think in this case, u can close the ticket pls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason For Change: Setting the lan-restart sysevent triggers IPv6 address assignment on brlan0. Since WANManager already handles brlan0 IPv6 assignment earlier in setUpLanPrefixIPv6(), setting this sysevent again later in the function is unnecessary and causes duplicate assignment. To avoid repetition and stale configuration, the lan-restart sysevent update has been removed from the later part of the function.
Risks: Low
Signed-off-by: Aiswarya Prasad aprasad@maxlinear.com