RDKCOM-5575: RDKBDEV-3419 ,RDKBACCL-1597: [TDK][AUTO][BPI][DML]Write-Type compliance fails for Device.X_RDK_WanManager.Interface.<i>.Alias#199
Conversation
…Device.X_RDK_WanManager.Interface.<i>.Alias Reason for change: Added SetHandler for Alias data model Test procedure: set operation for not valid datatype should fail for Device.X_RDK_WanManager.Interface.<i>.Alias Risks: Low Signed-off-by: ssiras826 <ssiras826@cable.comcast.com>
SsandhyaR
changed the title
|
PR is tracked at https://ccp.sys.comcast.net/browse/RDKCOM-5575 |
pradeeptakdas
changed the title
pradeeptakdas
changed the title
| CcspTraceInfo(("%s-%d : Selection Enable UnSub(%d) \n", __FUNCTION__, __LINE__, pWanDmlIface->Sub.WanEnableSub)); | ||
| } | ||
| } | ||
| else if(strstr(name, WANMGR_INFACE_ALIASNAME_SUFFIX)) |
There was a problem hiding this comment.
Is there a requirement to subscribe to the “Alias” event?
If so, I’d like to understand the details to ensure we are sending the events correctly.
There was a problem hiding this comment.
Hi @guto86 ,
modified the code with removing event, please review
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds RBUS set-handler support for updating a WAN interface’s AliasName and persisting it to PSM/DB.
Changes:
- Handle
...AliasNameparameter updates inWanMgr_Interface_SetHandler. - Copy the new alias into the in-memory interface object and persist it via
WanMgr_RdkBus_SetParamValuesToDB. - Log alias changes for visibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| char param_name[256] = {0}; | ||
| strncpy(AliasName, rbusValue_GetString(value, NULL), sizeof(AliasName)-1); | ||
| _ansc_sprintf(param_name, PSM_WANMANAGER_IF_ALIAS, index); |
| { | ||
| if (type == RBUS_STRING) | ||
| { | ||
| char AliasName[64] = {0}; |
| char param_name[256] = {0}; | ||
| strncpy(AliasName, rbusValue_GetString(value, NULL), sizeof(AliasName)-1); | ||
| _ansc_sprintf(param_name, PSM_WANMANAGER_IF_ALIAS, index); | ||
| strncpy(pWanDmlIface->AliasName, AliasName, sizeof(pWanDmlIface->AliasName)-1); |
| ret = RBUS_ERROR_INVALID_INPUT; | ||
| } | ||
| } | ||
| else if(strstr(name, WANMGR_INFACE_ALIASNAME_SUFFIX)) |
|
Hi @SsandhyaR, While the implementation looks good overall, we would like you to consider the Pub/Sub behavior. |
Hi @guto86 , |
Reason for change: Added SetHandler for Alias data model
Test procedure: set operation for not valid datatype should fail for Device.X_RDK_WanManager.Interface..Alias
Risks: Low