Skip to content

RDKCOM-5422: RDKBDEV-3258 Remove UTOPIA mcast services from the build#80

Open
satish-kotapati wants to merge 3 commits into
rdkcentral:developfrom
satish-kotapati:RDKBDEV-3258
Open

RDKCOM-5422: RDKBDEV-3258 Remove UTOPIA mcast services from the build#80
satish-kotapati wants to merge 3 commits into
rdkcentral:developfrom
satish-kotapati:RDKBDEV-3258

Conversation

@satish-kotapati

@satish-kotapati satish-kotapati commented Sep 25, 2025

Copy link
Copy Markdown

Reason for change: Utopia should have an option to not build mcast sources if it is not required on the platform
Test Procedure: binary presence based on the flag enablement
Risks: None

@satish-kotapati satish-kotapati requested a review from a team as a code owner September 25, 2025 07:59
@CLAassistant

CLAassistant commented Sep 25, 2025 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

github-actions Bot commented Sep 25, 2025 •
edited
Loading

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@pradeeptakdas pradeeptakdas changed the title RDKBDEV-3258 Remove UTOPIA mcast services from the build RDKCOM-5422: RDKBDEV-3258 Remove UTOPIA mcast services from the build Sep 28, 2025
@satish-kotapati satish-kotapati requested a review from a team as a code owner September 30, 2025 10:32
@Sukanya673 Sukanya673 requested a review from a team as a code owner October 9, 2025 04:40
anoopchelakkode
anoopchelakkode requested changes Oct 10, 2025
View reviewed changes

@anoopchelakkode anoopchelakkode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this default enabled? If yes, in current scenario how are these proxies enabled or disabled?

@satish-kotapati

satish-kotapati commented Nov 10, 2025

Copy link
Copy Markdown
Author

Is this default enabled? If yes, in current scenario how are these proxies enabled or disabled?

"no_utopia_mcast" won't be enabled by default so proxies would be enabled.
if there is a need to remove the proxy then distro feature needs to be enabled in conf, like : DISTRO_FEATURES:append = " no_utopia_mcast"

@AkhilaReddyK7 AkhilaReddyK7 added the community-contribution Contribution from community label Mar 17, 2026
apattu200
apattu200 reviewed Apr 9, 2026
View reviewed changes
Comment thread source/scripts/init/c_registration/Makefile.am
bin_PROGRAMS += 02_devicemode
endif

if ENABLE_MCAST_SERVICE

@apattu200 apattu200 Apr 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For existing platforms will this prevent MCAST bianaries. in corresponding META changes configure not properly set

@satish-kotapati satish-kotapati May 25, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you mentioning about bb file change or configure.ac ?

@satish-kotapati satish-kotapati May 26, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENABLE_MCAST_SERVICE = "${@bb.utils.contains('DISTRO_FEATURES', 'no_utopia_mcast', 'no', 'yes', d)}"
is the change made in bb file,
In your case :
DISTRO_FEATURES does NOT contain 'no_utopia_mcast'
ENABLE_MCAST_SERVICE = "yes"

@tinaelizabeth84 tinaelizabeth84 mentioned this pull request May 21, 2026
Open
@satish-kotapati @pradeeptakdas
RDKBDEV-3258 Remove UTOPIA mcast services from the build
e770a02 
Reason for change: Utopia should have an option to not build mcast sources if it is not required on the platform
Test Procedure: binary presence based on the flag enablement
Risks: None
Signed-off-by: sai satish kotapati  <skotapati@maxlinear.com>
Copilot AI review requested due to automatic review settings June 10, 2026 14:39
Copilot AI reviewed Jun 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a build-time option to exclude IGMP/MLD multicast service registration binaries from Utopia builds, and hardens init-time service startup to avoid calling multicast service scripts when they’re not present.

Changes:

  • Introduces --enable-igmpmld (default enabled) and ENABLE_MCAST_SERVICE automake conditional.
  • Gates 10_mcastproxy / 10_mldproxy (and their sources) behind ENABLE_MCAST_SERVICE in c_registration/Makefile.am.
  • Updates service_misc.sh to only invoke multicast proxy service scripts when the scripts exist.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
source/scripts/init/service.d/service_misc.sh Adds presence checks before launching multicast proxy service scripts during init.
source/scripts/init/c_registration/Makefile.am Makes multicast registration binaries conditional on ENABLE_MCAST_SERVICE.
configure.ac Adds --enable-igmpmld configure option and defines ENABLE_MCAST_SERVICE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/scripts/init/service.d/service_misc.sh
Comment on lines +78 to 80
if [[ "$RG_MD" = "1" -o "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mcastproxy.sh ]; then
/etc/utopia/service.d/service_mcastproxy.sh lan-status&
fi
Comment thread source/scripts/init/service.d/service_misc.sh
Comment on lines +82 to 84
if [[ "$RG_MD" = "2" -o "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mldproxy.sh ]; then
/etc/utopia/service.d/service_mldproxy.sh lan-status&
fi
Comment thread source/scripts/init/c_registration/Makefile.am
Copilot AI review requested due to automatic review settings June 24, 2026 20:33
Copilot AI reviewed Jun 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread source/scripts/init/service.d/service_misc.sh
Comment on lines +78 to 80
if [[ "$RG_MD" = "1" -o "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mcastproxy.sh ]; then
/etc/utopia/service.d/service_mcastproxy.sh lan-status&
fi
Comment thread source/scripts/init/service.d/service_misc.sh
Comment on lines +82 to 84
if [[ "$RG_MD" = "2" -o "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mldproxy.sh ]; then
/etc/utopia/service.d/service_mldproxy.sh lan-status&
fi
Comment thread source/scripts/init/service.d/service_misc.sh
Comment on lines +78 to 79
if [[ "$RG_MD" = "1" -o "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mcastproxy.sh ]; then
/etc/utopia/service.d/service_mcastproxy.sh lan-status&
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@anoopchelakkode anoopchelakkode anoopchelakkode requested changes

@apattu200 apattu200 apattu200 requested changes

@snayak002c snayak002c snayak002c approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@satish-kotapati satish-kotapati

Labels

community-contribution Contribution from community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@satish-kotapati @CLAassistant @anoopchelakkode @snayak002c @apattu200 @AkhilaReddyK7