RDKB-65724: Set Default RFC values on Fully Deployed RFC Features#352
Open
BaskarBabu25 wants to merge 1 commit into
Open
RDKB-65724: Set Default RFC values on Fully Deployed RFC Features#352BaskarBabu25 wants to merge 1 commit into
BaskarBabu25 wants to merge 1 commit into
Conversation
Reason for change: Default these RFC's to given config. Test Procedure:Ensure default value persists on FR scenario's and no functionality issue observed. Ensure the below values persist across reboot. Device.SelfHeal.X_RDKCENTRAL-COM_NoWaitLogSync : true Device.SelfHeal.X_RDKCENTRAL-COM_LogBackupThreshold : 3 Device.DeviceInfo.X_RDKCENTRAL-COM_xOpsDeviceMgmt.Logging.DmesgLogSyncInterval : 60 Risks: Low Priority: P1 Signed-off-by: baskarbabu_pitchandi@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
Updates platform default configuration values for SelfHeal log backup and dmesg log sync to align with the RFC defaults referenced in RDKB-65724.
Changes:
- Set
$dmesglogsync_intervaldefault from900to60(xd4/bci/arm). - Enable SelfHeal log backup by default and set
$log_backup_thresholdto3(xd4/bci/arm).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/scripts/init/defaults/system_defaults_xd4 | Adjusts xd4 defaults for dmesg log sync interval and SelfHeal log backup enable/threshold. |
| source/scripts/init/defaults/system_defaults_bci | Adjusts bci defaults for dmesg log sync interval and SelfHeal log backup enable/threshold. |
| source/scripts/init/defaults/system_defaults_arm | Adjusts arm defaults for dmesg log sync interval and SelfHeal log backup enable/threshold. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Default these RFC's to given config.
Test Procedure: Ensure default value persists on FR scenarios and no functionality issue observed. Ensure the below values persist across reboot.
Device.SelfHeal.X_RDKCENTRAL-COM_NoWaitLogSync : true
Device.SelfHeal.X_RDKCENTRAL-COM_LogBackupThreshold : 3
Device.DeviceInfo.X_RDKCENTRAL-COM_xOpsDeviceMgmt.Logging.DmesgLogSyncInterval : 60
Risks: Low
Priority: P1
Signed-off-by: baskarbabu_pitchandi@comcast.com
Unit test done and results attached.
https://ccp.sys.comcast.net/browse/RDKB-65724?focusedId=25588575&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-25588575