Re-Structure the rdk-gdcs/rdkb_common_utils#348
Conversation
Signed-off-by: Deepak-Rathn <deepak.rathn@gmail.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Pull request overview
This PR updates multiple Automake build recipes to support the re-structured rdkb_common_utils layout by adjusting how ONESTACK-specific libraries are linked (notably moving feature-gate libs into LDADD and adding onestack_syscfg).
Changes:
- Link
-lrdkb_feature_mode_gate(and newly-lonestack_syscfg) via per-target*_LDADDin several components. - Add sysroot
-L...$(libdir)search paths for ONESTACK builds where needed. - Refactor ONESTACK linking in init utilities to include additional ONESTACK libraries.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| source/service_routed/Makefile.am | Move ONESTACK feature-gate linking into service_routed_LDADD and add onestack_syscfg. |
| source/service_ipv6/Makefile.am | Add ONESTACK sysroot -L... and onestack_syscfg to link inputs (currently introduces a flag overwrite issue). |
| source/scripts/init/src/apply_system_defaults/Makefile.am | Switch ONESTACK link inputs from global AM_LDFLAGS to target-specific variables (currently mixes -L into LDADD). |
| source/scripts/init/c_registration/Makefile.am | Add ONESTACK sysroot -L..., devicemode/telemetry libs, and append feature-gate + onestack_syscfg. |
| source/firewall/Makefile.am | Add ONESTACK sysroot -L... and move feature-gate + onestack_syscfg into per-target *_LDADD for both binaries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| service_ipv6_LDFLAGS = -L${PKG_CONFIG_SYSROOT_DIR}${libdir} | ||
| service_ipv6_LDADD += -lrdkb_feature_mode_gate -ltelemetry_msgsender -lonestack_syscfg |
|
|
||
| if ONESTACK_PRODUCT_REQ | ||
| AM_LDFLAGS += -L${PKG_CONFIG_SYSROOT_DIR}$(libdir) -ldevicemode -lonestack_syscfg -lonestack_log -lonestack_init | ||
| apply_system_defaults_LDADD = -L${PKG_CONFIG_SYSROOT_DIR}$(libdir) -ldevicemode -lonestack_syscfg -lonestack_log -lonestack_init |
Signed-off-by: Deepak-Rathn <deepak.rathn@gmail.com>
Signed-off-by: Deepak-Rathn <deepak.rathn@gmail.com>
No description provided.