RDKCOM-5595: RDKBDEV-3450 The CM is not updated with DNS Name (Option15), instead utopia.net is displayed in LAN side provisioning.#341
Open
aprasad-97 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds DHCP domain-name propagation into the udhcpc service’s data path so it can be stored and logged alongside existing DHCP lease fields.
Changes:
- Introduces a
DHCP_DOMAIN_NAMEenvironment key. - Logs the domain value in
handle_wan. - Reads the DHCP domain from the environment into
ipc_dhcpv4_data_t.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1000
to
1002
| OnboardLog("[%s][%d] mask = %s \n", __FUNCTION__, __LINE__,data.mask); | ||
| OnboardLog("[%s][%d] domain = %s \n", __FUNCTION__, __LINE__,data.domain); | ||
| OnboardLog("[%s][%d] gateway = %s \n",__FUNCTION__, __LINE__,data.gateway); |
Comment on lines
+1341
to
+1350
| /** Domain name */ | ||
| if ((env = getenv(DHCP_DOMAIN_NAME)) != NULL) | ||
| { | ||
| safec_rc = strcpy_s(dhcpv4_data->domain, sizeof(dhcpv4_data->domain), env); // CID 187457: Buffer not null terminated (BUFFER_SIZE) | ||
| ERR_CHK(safec_rc); | ||
| } | ||
| else | ||
| { | ||
| OnboardLog("[%s-%d] Domain name is not available \n", __FUNCTION__,__LINE__); | ||
| } |
pradeeptakdas
changed the title
…d utopia.net is displayed in LAN side provisioning. Reason for change: Added provisioning to fetch the DHCPv4 Option 15 (Domain Name) value via udhcpc and forward it to the WAN Manager. The WAN Manager then sets the corresponding sysevent, enabling dnsmasq to propagate the domain name to LAN clients. Risks: Low Signed-off-by: Aiswarya Prasad <aprasad@maxlinear.com>
AkhilaReddyK7
force-pushed
the
RDKBDEV-3450
branch
from
503d9cb to
43c3895
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added provisioning to fetch the DHCPv4 Option 15 (Domain Name) value via udhcpc and forward it to the WAN Manager. The WAN Manager then sets the corresponding sysevent, enabling dnsmasq to propagate the domain name to LAN clients.
Risks: Low