Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1077,6 +1077,7 @@ fi
fi

#echo "interface=$LAN_IFNAME" >> $LOCAL_DHCP_CONF
echo "bind-dynamic" >> $LOCAL_DHCP_CONF

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already passing bind-dynamic as an argument to dnsmasq. If it is not handled in some scenarios, please fix that. Otherwise, remove bind-dynamic from the arguments and keep it only in the configuration file. We should not maintain this option in both the config file and the dnsmasq arguments.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snayak002c , May I know whether bind-dynamic is passed as an argument on bpi? I can see that its enabled only to specific platforms. https://github.com/rdkcentral/utopia/blob/main/source/service_dhcp/service_dhcp_server.c#L308

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aprasad-97 Its not an argument on BPI, Please make it available for all platforms. Either we can keep it in config file or pass it as an argument. Since we are passing it as argument for some platforms please see if we can enable it for all the platforms that way itself.Component owner is asking not to keep it as part of both.

echo "expand-hosts" >> $LOCAL_DHCP_CONF
echo "address=/.c.f.ip6.arpa/" >> $LOCAL_DHCP_CONF

Expand Down
Loading