RDKEMW-20104:gst-cleanup conditions when cdl_flashed_file_name is not present#556
Merged
Conversation
… present Reason for change: gstreamer-cleanup is happening on every reboot when /opt/cdl_flashed_file_name is missing. Fixing the issue as well as re-locating gstreamer-cleanup.service file to recipies-multimedia instead of sysint folder Test Procedure: Boot the TV and check for gstreamer-cleanup metrics in rdk_milestones.log Risks: low Signed-off-by: Renuka Varry <rvarry049_comcast@cable.comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to stop unintended gstreamer-cleanup runs on every reboot when /opt/cdl_flashed_file_name is missing, and to relocate the gstreamer-cleanup.service unit out of this repo’s systemd_units/ directory.
Changes:
- Removes
systemd_units/gstreamer-cleanup.servicefrom this repository.
Comments suppressed due to low confidence (1)
systemd_units/gstreamer-cleanup.service:1
- This change deletes
systemd_units/gstreamer-cleanup.service, but there is no replacementgstreamer-cleanup.serviceanywhere else in this repo. That means this PR (as-is) removes the gstreamer cleanup service entirely and does not implement the title/description’s “fix + relocation” within this codebase. If the service is being moved to another layer/repo, please either (a) include the new unit file here in its new location, or (b) update the PR description to explicitly state that this PR only removes the unit from sysint and link to the PR/repo where the corrected unit is added.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nhanasi
approved these changes
Jun 16, 2026
nhanasi
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: gstreamer-cleanup is happening on every reboot when /opt/cdl_flashed_file_name is missing. Fixing the issue as well as re-locating gstreamer-cleanup.service file to recipies-multimedia instead of sysint folder
Test Procedure: Boot the TV and check for gstreamer-cleanup metrics in rdk_milestones.log
Risks: low