Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SD_CARD_MOUNT_PATHis now defined here, but other scripts/configs in this repo also rely onSD_CARD_APP_MOUNT_PATH(anddisk_initeven notes thatdevice.propertiesshould overwrite these defaults). Sincefactory-reset.sh,warehouse-reset.sh, andwh_api_5.confsource/etc/device.propertiesdirectly, leavingSD_CARD_APP_MOUNT_PATHundefined can result in those paths expanding to empty (e.g.,/netflix/...) and skipping intended cleanup/checks. Consider definingSD_CARD_APP_MOUNT_PATHhere as well (it defaults to/media/appsinlib/rdk/disk_init).