RDKB-65279 : Default OCSP stapling parameters#39
Open
Ananth916 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates ocsp-support.sh to “default” OCSP stapling and OCSP CA behavior to enabled by writing EnableOCSPStapling / EnableOCSPCA into syscfg, aligning runtime behavior with the stated goal of defaulting OCSP-related RFC behavior to true.
Changes:
- Adds logic to force-set
EnableOCSPStapling=truewhen the current status is not"true". - Adds logic to force-set
EnableOCSPCA=truewhen the current status is not"true". - Re-reads
syscfgvalues after applying defaults and logs the resulting status.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+36
to
+46
| if [ "$StatusOCSPSTAPLE" != "true" ]; then | ||
| echo "Defaulting StatusOCSPSTAPLE set to true" >> $OCSP_LOG_FILE | ||
| syscfg set "EnableOCSPStapling" "true" | ||
| syscfg commit | ||
| fi | ||
|
|
||
| if [ "$StatusOCSPCA" != "true" ]; then | ||
| echo "Defaulting StatusOCSPCA set to true" >> $OCSP_LOG_FILE | ||
| syscfg set "EnableOCSPCA" "true" | ||
| syscfg commit | ||
| fi |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Defaulting OCSP RFC to true
Test Procedure: Build & Verify
Risks: Low
Priority: P1